Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing return in ListGrid.hasChanges() #33

Closed
GoogleCodeExporter opened this issue Apr 22, 2015 · 4 comments
Closed

Missing return in ListGrid.hasChanges() #33

GoogleCodeExporter opened this issue Apr 22, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

The hasChanges method in the ListGrid class is declared as follows:

public void hasChanges()

In order to be useful, it needs to return something.

What version of the product are you using? On what operating system?
smartgwt-1.0b1

Please provide any additional information below.
Copied from: http://forums.smartclient.com/showthread.php?p=12702#post12702

Original issue reported on code.google.com by andrewaw...@gmail.com on 5 Dec 2008 at 1:17

@GoogleCodeExporter
Copy link
Author

Looking through the ListGrid JavaDoc, it appears that there are a number of 
other
methods with void returns, where something should.  cellHasChanges(int rowNum, 
int
colNum) and getDrawnRows() are the first two that I've come across.  I guess 
that
return types will be added as development proceeds.

Original comment by andrewaw...@gmail.com on 6 Dec 2008 at 2:48

@GoogleCodeExporter
Copy link
Author

I have fixed hasChanges and cellHasChanges. I'll take care as getDrawnRows as 
well. 
Portions of SmartGWT were generated from metadata and the metadata of a few  
methods 
like the ones you mention were incorrect and did not have a return type. Please 
report any other such inconsistencies. 

Original comment by sanjiv.j...@gmail.com on 6 Dec 2008 at 2:55

@GoogleCodeExporter
Copy link
Author

Original comment by sanjiv.j...@gmail.com on 9 Dec 2008 at 1:19

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

All should be fixed in build 12-17-2008.

Original comment by sanjiv.j...@gmail.com on 17 Dec 2008 at 12:06

  • Changed state: Fixed
  • Added labels: 12-17-2008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant