New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide inactive/offline devices from map #205

Closed
peptoni opened this Issue Jun 30, 2015 · 9 comments

Comments

Projects
None yet
3 participants
@peptoni

peptoni commented Jun 30, 2015

Would it be possible/interesting to add an option to hide inactive/offline devices from map?

@antoniopaisfernandes

This comment has been minimized.

Show comment
Hide comment
@antoniopaisfernandes

antoniopaisfernandes Jul 1, 2015

Contributor

I second that :)

Contributor

antoniopaisfernandes commented Jul 1, 2015

I second that :)

@peptoni

This comment has been minimized.

Show comment
Hide comment
@peptoni

peptoni Jul 1, 2015

It could be a "Hide all inactive/offline" option, or a "Hide by device" option

peptoni commented Jul 1, 2015

It could be a "Hide all inactive/offline" option, or a "Hide by device" option

@vitalidze

This comment has been minimized.

Show comment
Hide comment
@vitalidze

vitalidze Jul 2, 2015

Owner

I thought about both options - hide all and per device setting. The setting
may be in user's preferences. In my mind it looks like that setting for
"all devices" should have higher priority than a per-device setting. What
do you think?

среда, 1 июля 2015 г. пользователь peptoni написал:

It could be a "Hide all inactive/offline" option, or a "Hide by device"
option


Reply to this email directly or view it on GitHub
#205 (comment)
.

Kind regards, Vitaly Litvak

Owner

vitalidze commented Jul 2, 2015

I thought about both options - hide all and per device setting. The setting
may be in user's preferences. In my mind it looks like that setting for
"all devices" should have higher priority than a per-device setting. What
do you think?

среда, 1 июля 2015 г. пользователь peptoni написал:

It could be a "Hide all inactive/offline" option, or a "Hide by device"
option


Reply to this email directly or view it on GitHub
#205 (comment)
.

Kind regards, Vitaly Litvak

@peptoni

This comment has been minimized.

Show comment
Hide comment
@peptoni

peptoni Jul 2, 2015

I agree that "hide all devices" option should have higher priority than per-device setting.
Should you treat "inactive" separate from "offline"...?
I mean: one setting for hiding inactive devices and another for hiding offline devices...

peptoni commented Jul 2, 2015

I agree that "hide all devices" option should have higher priority than per-device setting.
Should you treat "inactive" separate from "offline"...?
I mean: one setting for hiding inactive devices and another for hiding offline devices...

@peptoni

This comment has been minimized.

Show comment
Hide comment
@peptoni

peptoni Jul 2, 2015

Sorry... I just realized I already asked for this enhacement on #118...

peptoni commented Jul 2, 2015

Sorry... I just realized I already asked for this enhacement on #118...

@vitalidze

This comment has been minimized.

Show comment
Hide comment
@vitalidze

vitalidze Jul 2, 2015

Owner

By "active" you mean selected device? I thought just about "offline"
devices.

четверг, 2 июля 2015 г. пользователь peptoni написал:

Sorry... I just realized I already asked for this enhacement on #118
#118...


Reply to this email directly or view it on GitHub
#205 (comment)
.

Kind regards, Vitaly Litvak

Owner

vitalidze commented Jul 2, 2015

By "active" you mean selected device? I thought just about "offline"
devices.

четверг, 2 июля 2015 г. пользователь peptoni написал:

Sorry... I just realized I already asked for this enhacement on #118
#118...


Reply to this email directly or view it on GitHub
#205 (comment)
.

Kind regards, Vitaly Litvak

@peptoni

This comment has been minimized.

Show comment
Hide comment
@peptoni

peptoni Jul 2, 2015

Offline would be the devices that are not transmitting. Devices off.
Inactive would be the devices that don't move for a period of time, but still transmit. Devices on.

peptoni commented Jul 2, 2015

Offline would be the devices that are not transmitting. Devices off.
Inactive would be the devices that don't move for a period of time, but still transmit. Devices on.

@vitalidze

This comment has been minimized.

Show comment
Hide comment
@vitalidze

vitalidze Jul 2, 2015

Owner

I see. In current terminology of web UI the "inactive" devices are called
"idle". Well, I don't know whether it's worth to add an option to hide such
devices. But it does not make big difference in implementation means.

четверг, 2 июля 2015 г. пользователь peptoni написал:

Offline would be the devices that are not transmitting. Devices off.
Inactive would be the devices that don't move for a period of time, but
still transmit. Devices on.


Reply to this email directly or view it on GitHub
#205 (comment)
.

Kind regards, Vitaly Litvak

Owner

vitalidze commented Jul 2, 2015

I see. In current terminology of web UI the "inactive" devices are called
"idle". Well, I don't know whether it's worth to add an option to hide such
devices. But it does not make big difference in implementation means.

четверг, 2 июля 2015 г. пользователь peptoni написал:

Offline would be the devices that are not transmitting. Devices off.
Inactive would be the devices that don't move for a period of time, but
still transmit. Devices on.


Reply to this email directly or view it on GitHub
#205 (comment)
.

Kind regards, Vitaly Litvak

vitalidze added a commit that referenced this issue Dec 10, 2015

vitalidze added a commit that referenced this issue Dec 10, 2015

For #118 #205 #382 - implemented dynamic visibility calculation based…
… on the status of device, handle the 'forced' visibility and 'hidden' flags

vitalidze added a commit that referenced this issue Dec 10, 2015

vitalidze added a commit that referenced this issue Dec 10, 2015

@vitalidze

This comment has been minimized.

Show comment
Hide comment
@vitalidze

vitalidze Dec 10, 2015

Owner

Implemented, written news and article, updated latest and demo version.

Owner

vitalidze commented Dec 10, 2015

Implemented, written news and article, updated latest and demo version.

@vitalidze vitalidze closed this Dec 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment