feat: add experimental PWA assets generation and injection #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
userquin
commented
Dec 13, 2023
userquin
commented
Dec 13, 2023
|
Excited for this PR! |
userquin
commented
Dec 13, 2023
userquin
commented
Dec 13, 2023
userquin
changed the title
userquin
commented
Dec 14, 2023
userquin
commented
Dec 16, 2023
userquin
commented
Dec 16, 2023
userquin
commented
Dec 16, 2023
userquin
commented
Dec 16, 2023
# Conflicts: # package.json
11 tasks
# Conflicts: # src/options.ts # src/types.ts
|
Moved pwa assets dependency to optional peer, here small repro if someone want to check it https://github.com/userquin/vite-plugin-pwa-assets-generator (local tgz from this PR) |
# Conflicts: # src/plugins/dev.ts
This was referenced Feb 17, 2024
renovate bot
added a commit
to SebastianGoeb/chinese-chart
that referenced
this pull request
Feb 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vite-plugin-pwa](https://togithub.com/vite-pwa/vite-plugin-pwa) | [`^0.18.0` -> `^0.19.0`](https://renovatebot.com/diffs/npm/vite-plugin-pwa/0.18.1/0.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vite-pwa/vite-plugin-pwa (vite-plugin-pwa)</summary> ### [`v0.19.0`](https://togithub.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.19.0) [Compare Source](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.18.2...v0.19.0) ##### 🚨 Breaking Changes - Add experimental PWA assets generation and injection - by [@​userquin](https://togithub.com/userquin) in [vite-pwa/vite-plugin-pwa#621 [<samp>(d9ffc)</samp>](https://togithub.com/vite-pwa/vite-plugin-pwa/commit/d9ffcb5) ##### [View changes on GitHub](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.18.2...v0.19.0) ### [`v0.18.2`](https://togithub.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.18.2) [Compare Source](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.18.1...v0.18.2) ##### 🐞 Bug Fixes - Use `swDest` folder to resolve mjs and map files in Vite build - by [@​userquin](https://togithub.com/userquin) in [vite-pwa/vite-plugin-pwa#661 [<samp>(aaa85)</samp>](https://togithub.com/vite-pwa/vite-plugin-pwa/commit/aaa856b) ##### [View changes on GitHub](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.18.1...v0.18.2) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SebastianGoeb/chinese-chart). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOTEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE5MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes PWA assets generator
0.2.2, with the following features:color_themein the html head metatheme-color: enabled by defaultid-modified-sinceheader) and cache invalidation on configuration changevirtual:pwa-assets/headandvirtual:pwa-assets/iconsYou can run the
assets-generatorexample in dev or building and preview:pnpm install && pnpm buildassets-generatorexample:cd examples/assets-generatorpnpm dev) or build + preview (pnpm build && pnpm preview)