Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Users are foreced to put "@pika/react" in their dependencies #20

Closed
csr632 opened this issue Aug 11, 2020 · 1 comment · Fixed by #34
Closed

Users are foreced to put "@pika/react" in their dependencies #20

csr632 opened this issue Aug 11, 2020 · 1 comment · Fixed by #34

Comments

@csr632
Copy link
Member

csr632 commented Aug 11, 2020

Users are foreced to put "@pika/react" in their dependencies. Although this is reasonable for app development, it is not suitable for library development.

If user put @pika/react in devDependencies, the optimize step will bundle react into optimized bundle, which leads to duplicate react error in dev. Reproduce: https://github.com/csr632/test-vite/tree/pika-react-dev-dep

@aleclarson
Copy link
Member

aleclarson commented Oct 4, 2020

vitejs/vite#838 will fix this for most cases. As long as locally developed packages don't have @pika/react installed, that PR will fall back to the app's node_modules.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants