Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to ESM #101

Merged
merged 1 commit into from May 8, 2023
Merged

feat: switch to ESM #101

merged 1 commit into from May 8, 2023

Conversation

ArnaudBarre
Copy link
Member

@ArnaudBarre ArnaudBarre commented May 7, 2023

Tested by switching one of the playground to node16, it works, but I'm still afraid of other side effects.

Fixes: #95

(I'm waiting for esbuild to provide support for the new decorators spec for the next major)

@ArnaudBarre ArnaudBarre requested a review from bluwy May 7, 2023 23:29
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I've understand with how tools use the package.json type so far, I think this should be safe.

@ArnaudBarre ArnaudBarre merged commit 810de09 into main May 8, 2023
1 check passed
@ArnaudBarre ArnaudBarre deleted the change-module-type branch May 8, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible with typescript node16 resolution with type: module
2 participants