perf: avoid fsp.unlink if we don't use the promise (#12589)

vitejs · Mar 26, 2023 · 19d1980 · 19d1980
1 parent 4215e22
commit 19d1980
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts
@@ -1093,11 +1093,7 @@ async function loadConfigFromBundledFile(
     try {
       return (await dynamicImport(fileUrl)).default
     } finally {
-      try {
-        await fsp.unlink(fileNameTmp)
-      } catch {
-        // already removed if this function is called twice simultaneously
-      }
+      fs.unlink(fileNameTmp, () => {}) // Ignore errors
     }
   }
   // for cjs, we can register a custom loader via `_require.extensions`

diff --git a/packages/vite/src/node/optimizer/index.ts b/packages/vite/src/node/optimizer/index.ts
@@ -626,7 +626,7 @@ export function runOptimizeDeps(
 
             // Clean up old files in the background
             for (const filePath of oldFilesPaths)
-              if (!newFilesPaths.has(filePath)) fsp.unlink(filePath)
+              if (!newFilesPaths.has(filePath)) fs.unlink(filePath, () => {}) // ignore errors
 
             await Promise.all(files)
           },