Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly close optimizer on server restart #10028

Merged
merged 1 commit into from
Sep 23, 2022
Merged

fix: properly close optimizer on server restart #10028

merged 1 commit into from
Sep 23, 2022

Conversation

patak-dev
Copy link
Member

Description

Possible fix for #9986

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@IanVS
Copy link
Contributor

IanVS commented Sep 7, 2022

This does seem to avoid the ENOENT issue reported in #9986 in my reproduction. However, I'm not sure that it solves the root cause that was triggering the error in the first place, which seems to happen when I have multiple versions of some dependencies in my node_modules. But, I'll try to isolate down that case and make a new issue, and I think this is a good change to make regardless.

bluwy
bluwy approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patak-dev patak-dev merged commit a32777f into main Sep 23, 2022
@patak-dev patak-dev deleted the fix/optimizer-clean-up branch September 23, 2022 15:30
@patak-dev patak-dev added p3-minor-bug An edge case that only affects very specific usage (priority) feat: deps optimizer Esbuild Dependencies Optimization labels Sep 23, 2022
@patak-dev patak-dev added this to the 3.2 milestone Sep 23, 2022
@patak-dev patak-dev mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: deps optimizer Esbuild Dependencies Optimization p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@patak-dev @IanVS @bluwy