feat(lib): cjs instead of umd as default format for multiple entries #10315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #7047. I propose to use different default
format
settings when using multiple entries in lib mode.At the moment using a config like this:
will result in an error
That is because, if not specified otherwise, the output formats in lib mode will be
['es', 'umd']
and Rollup does not support multiple entry points for UMD (rollup/rollup#2072). Since this is not a nice user experience, I think it's better to not use UMD by default - if multiple entries are used. Instead CommonJs could be used, which is at least a part of UMD, minus the AMD part.Additional context
Since multiple entries are not released yet, this is not a breaking change. If we can get it in before 3.2 😉
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).