fix(ssr): handle parallel hookNodeResolve #10401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hookNodeResolve
is called in an asyncnodeImport
which could run in parallel on multiple calls ofssrLoadModule
. This PR tracks the hook and unhook accordingly when all parallel calls are finished.Additional context
Fixes withastro/astro#4533
This was discussed before with @aleclarson at https://discord.com/channels/804011606160703521/930868117234647092/930868121118584913
No tests added since there wasn't a test before, but I feel like we should remove this hack in Vite 4, especially that we're going forward with ESM output.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).