Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leave fully dynamic import.meta.url asset (fixes #10306) #10549

Merged

Conversation

sapphi-red
Copy link
Member

Description

new URL(`${dynamic}`, import.meta.url)

is transformed to

new URL(import.meta.glob('**', { eager: true, import: 'default', as: 'url' }))[dynamic]), self.location)

This will collect all files in the file system.
But this is not a desired behavior.
This PR makes that leave as-is and output a warning. Maybe we don't need a warning?

fixes #10306

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Oct 20, 2022
@patak-dev patak-dev merged commit 56802b1 into vitejs:main Apr 2, 2023
@sapphi-red sapphi-red deleted the fix/leave-fully-dynamic-import-meta-url branch April 2, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import glob, operation not permitted
3 participants