Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transform import.meta.glob when scan JS/TS #10634 #10635

Merged
merged 2 commits into from
Nov 1, 2022
Merged

fix: transform import.meta.glob when scan JS/TS #10634 #10635

merged 2 commits into from
Nov 1, 2022

Conversation

candy-Tong
Copy link
Contributor

@candy-Tong candy-Tong commented Oct 25, 2022 •
edited by sapphi-red
Loading

Description

fixes #10634

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release feat: deps optimizer Esbuild Dependencies Optimization labels Oct 26, 2022
sapphi-red
sapphi-red approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sapphi-red sapphi-red changed the title feat: transform import.meta.glob when scan JS/TS #10634 fix: transform import.meta.glob when scan JS/TS #10634 Nov 1, 2022
@patak-dev patak-dev merged commit c53ffec into vitejs:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev Awaiting requested review from patak-dev

Assignees
No one assigned
Labels
feat: deps optimizer Esbuild Dependencies Optimization p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vite do not scan the dependency when using import.meta.glob
4 participants
@candy-Tong @bluwy @sapphi-red @patak-dev