-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing broken for preview with react-router-dom in 4.0.0-alpha.2 #10925
Comments
Some notes:
|
Testing Vite 4 with îles. An unintended effect of #10475 is that This is important to be able to locally preview sites that will be deployed using Ideally, frameworks like îles should be able to override |
I can confirm this error in vite 4.0.0 (stable) as well. |
I can confirm this too, everything works fine with v3 I tried to run the build folder with server and it works correctly |
I have the same issue on a Vue 3 project |
I just installed v4.0.1 and my problem has been solved.
|
Describe the bug
When going to
/some/route/somewhere
using react-router-dom with preview the query path is not passed to the route leading to a 404 error.In local dev it works fine.
git bisect
indicates this PR is the cause:#10475
Reproduction
https://stackblitz.com/edit/vitejs-vite-f9vj36?file=package.json,src%2FApp.jsx,vite.config.js&terminal=build,preview
Steps to reproduce
note: the StackBlitz link will run a build then run preview from the terminal query param. In dev the problem does not appear to happen.
Go to
/test/about
in the StackBlitz repro:System Info
Used Package Manager
yarn
Logs
No response
Validations
The text was updated successfully, but these errors were encountered: