Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update @types/node to v18 #11195

Merged
merged 2 commits into from
Dec 5, 2022
Merged

chore: update @types/node to v18 #11195

merged 2 commits into from
Dec 5, 2022

Conversation

sapphi-red
Copy link
Member

Description

This PR updates @types/node to v18 and fixes the built file type check script.

I'm not sure if this script covers #8701, but I checked that this covers #8352 and #10678.

Superseds close #11183

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority) labels Dec 5, 2022
@sapphi-red sapphi-red added this to the 4.0 milestone Dec 5, 2022
@patak-dev patak-dev merged commit 4ec9f53 into vitejs:main Dec 5, 2022
@sapphi-red sapphi-red deleted the chore/update-node-types branch December 5, 2022 12:23
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sapphi-red @futurGH
chore: update @types/node to v18 (vitejs#11195)
701a8f5
@fi3ework fi3ework mentioned this pull request Mar 12, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @patak-dev