-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add \0
to virtual files id
#11261
Conversation
if (id === modulePreloadPolyfillId) { | ||
return id | ||
return resolvedModulePreloadPolyfillId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
@sapphi-red we may need to wait until the next minor for this one |
@patak-dev I think it's slightly safer to include this in 4.0. But I'm ok with delaying this until 4.1. |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
You're right, it was just the base commit |
Description
If the resolvedId doesn't start with
\0
, that parent directory will be watched by rollup.This PR changes the id and resolvedId for virtual files to avoid that.
fixes #10096
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).