Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect base when using /__open-in-editor #11337

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix: respect base when using /__open-in-editor #11337

merged 1 commit into from
Dec 12, 2022

Conversation

sapphi-red
Copy link
Member

Description

fixes #8627

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 12, 2022
@patak-dev patak-dev merged commit 8856c2e into vitejs:main Dec 12, 2022
@dominikg dominikg mentioned this pull request Dec 12, 2022
Closed
@sapphi-red sapphi-red deleted the fix/open-in-editor-base branch December 13, 2022 11:43
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sapphi-red @futurGH
fix: respect base when using /__open-in-editor (vitejs#11337)
42aff88 
fixes vitejs#8627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetch('/__open-in-editor') in error overlay does not respect base
2 participants
@sapphi-red @patak-dev