fix(hmr): base default protocol on client source location #11497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derive the default HMR protocol on the location where `client.ts` is imported from instead of `window.location`. Now, HMR works out of the box if the page is served over HTTPS while the Vite serves it files over HTTP.
bluwy
approved these changes
Dec 28, 2022
bluwy
added
feat: hmr
p3-minor-bug
sapphi-red
approved these changes
Dec 31, 2022
There was a problem hiding this comment.
Thanks!
We have setup related tests here.
I guess simply removing these lines would work.
https://github.com/sapphi-red/vite-setup-catalogue/blob/abde225a7bcdd608370343dc218f5d92a7145fe7/tests/fixtures/backend-https-vite-http/vite.config.js#L10-L12
Just in case, the tests won't pass if you didn't link the local Vite.
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Derive the default HMR protocol on the location where
client.tsis imported from instead ofwindow.location. Now, HMR works out of the box if the page is served over HTTPS while the Vite serves its files over HTTP.This PR is missing a test. I’d be happy to add one if someone points me to the right place for this.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).