Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "load sourcemaps alongside modules (#11576)" #11775

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

benmccann
Copy link
Collaborator

Description

Reverts #11576 as it's causing failures on the ecosystem CI: #11576 (comment)

Additional context

I'd love to get better source map support added, but source map support is pretty finicky in my experience and the PR being reverted didn't have any tests. We should probably make sure anything source map related has tests and is run against the ecosystem CI before merging on the next attempt. We reverted another attempt at source map support earlier for similar reasons


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann changed the title fix: Revert "fix(ssr): load sourcemaps alongside modules (fix: #3288) (#11576)" fix: Revert "load sourcemaps alongside modules (#11576)" Jan 20, 2023
@benmccann benmccann changed the title fix: Revert "load sourcemaps alongside modules (#11576)" fix: revert "load sourcemaps alongside modules (#11576)" Jan 20, 2023
@patak-dev
Copy link
Member

Thanks Ben, I agree. @Vap0r1ze let's try again for 4.2, it was good at least to check how it worked in the wild and find out these issues. Thanks!

@patak-dev patak-dev merged commit 697dd00 into vitejs:main Jan 20, 2023
@benmccann benmccann deleted the revert-sourcemaps branch January 20, 2023 21:29
@jere2101
Copy link

@patak-dev should we reopen #3288 then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants