Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scope tracking for shadowing variables in blocks (#11806) #11811

Merged
merged 1 commit into from
Jan 25, 2023
Merged

fix: scope tracking for shadowing variables in blocks (#11806) #11811

merged 1 commit into from
Jan 25, 2023

Conversation

gtm-nayan
Copy link
Contributor

Description

closes #11806

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: ssr p2-edge-case Bug, but has workaround or limited in scope (priority) labels Jan 25, 2023
@bluwy bluwy mentioned this pull request Jan 25, 2023
Merged
5 tasks
@patak-dev patak-dev merged commit 568bdab into vitejs:main Jan 25, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@gtm-nayan @futurGH
fix: scope tracking for shadowing variables in blocks (vitejs#11806) (v…
3c50985 
…itejs#11811)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: ssr p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed transformation due to bad scope analysis for catch blocks
3 participants
@gtm-nayan @patak-dev @sapphi-red