Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update CJS interop error message #11842

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: update CJS interop error message #11842

merged 1 commit into from
Jan 30, 2023

Conversation

epreston
Copy link
Contributor

Update error message to match build version.

Description

A warning message references the previous version of vite.

Additional context

It's a very small change. Changed number from 3 to 4. Ran into this today and I thought my build environment had reverted to 3.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Update error message to match build version.
@epreston epreston changed the title Update index.cjs style: update index.cjs Jan 29, 2023
@bluwy bluwy changed the title style: update index.cjs fix: update CJS interop error message Jan 30, 2023
@bluwy bluwy merged commit 356ddfe into vitejs:main Jan 30, 2023
@bluwy
Copy link
Member

bluwy commented Jan 30, 2023

Thanks! Good catch

@epreston epreston deleted the patch-1 branch January 30, 2023 11:16
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants