Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pluginContainer): simplify error position judge condition #12003

Merged
merged 1 commit into from
Feb 11, 2023
Merged

chore(pluginContainer): simplify error position judge condition #12003

merged 1 commit into from
Feb 11, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Feb 9, 2023

Description

Just a small change to simplify error position judge condition in pluginContainer.ts

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy merged commit e3ef9f4 into vitejs:main Feb 11, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sun0day @futurGH
chore(pluginContainer): simplify error position judge condition (vite…
5ab4018 
…js#12003)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sun0day @bluwy