Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import-analysis): improve error for jsx to not be preserve in tsconfig #12018

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

SyMind
Copy link
Contributor

@SyMind SyMind commented Feb 10, 2023

Description

When the jsx of tsconfig in the project is set to preserve, the Vitest error message is as follows:

If you are using JSX, make sure to name the file with the .jsx or .tsx extension.

It is confusing, so when the file is .jsx or .tsx, the message is prompted as follows:

If you use tsconfig.json, make sure don't set jsx to preserve.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@SyMind SyMind changed the title jsx cannot be preserve in tsconfig chore: jsx cannot be preserve in tsconfig Feb 10, 2023
@bluwy bluwy changed the title chore: jsx cannot be preserve in tsconfig fix(import-analysis): improve error for jsx to not be preserve in tsconfig Feb 12, 2023
@bluwy bluwy enabled auto-merge (squash) February 12, 2023 19:01
@bluwy bluwy disabled auto-merge February 22, 2023 08:15
@bluwy bluwy enabled auto-merge (squash) February 22, 2023 08:17
@bluwy bluwy merged commit 91fac1c into vitejs:main Feb 22, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants