-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct access to crossOrigin
attribute
#12023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
added
bug
p3-minor-bug
An edge case that only affects very specific usage (priority)
labels
Feb 11, 2023
bluwy
previously approved these changes
Feb 13, 2023
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
sapphi-red
reviewed
Feb 14, 2023
if (script.referrerpolicy) fetchOpts.referrerPolicy = script.referrerpolicy | ||
if (script.crossorigin === 'use-credentials') | ||
if (link.integrity) fetchOpts.integrity = link.integrity | ||
if (link.referrerpolicy) fetchOpts.referrerPolicy = link.referrerpolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (link.referrerpolicy) fetchOpts.referrerPolicy = link.referrerpolicy | |
if (link.referrerPolicy) fetchOpts.referrerPolicy = link.referrerPolicy |
'referrerPolicy' in document.createElement('link') // true
'referrerpolicy' in document.createElement('link') // false
It seems this one is also wrong. (applied this change)
sapphi-red
approved these changes
Feb 14, 2023
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Credit to @Rich-Harris for this. He noticed that the casing was wrong here:
Also renaming the variable here since the function is only called with a
link
and not ascript
Additional context
Even with the fix, the feature still seems pretty broken: #5532
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).