Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client-inject): replace globalThis.process.env.NODE_ENV (fix #12185) #12194

Merged
merged 2 commits into from
Feb 25, 2023
Merged

fix(client-inject): replace globalThis.process.env.NODE_ENV (fix #12185) #12194

merged 2 commits into from
Feb 25, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Feb 25, 2023

Description

fix #12185

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

devvsakib
devvsakib previously approved these changes Feb 25, 2023
View reviewed changes
Copy link

@devvsakib devvsakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluwy bluwy enabled auto-merge (squash) February 25, 2023 09:23
@bluwy bluwy merged commit 2063648 into vitejs:main Feb 25, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sun0day @futurGH
fix(client-inject): replace globalThis.process.env.NODE_ENV (fix vite…
e888cd0 
…js#12185) (vitejs#12194)
This was referenced Jun 29, 2023
Closed
Merged
@cailloumajor cailloumajor mentioned this pull request Jul 11, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@devvsakib devvsakib devvsakib left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected string when using globalThis.process.env.NODE_ENV
3 participants
@sun0day @bluwy @devvsakib