fix(optimizer): # symbol in deps id stripped by browser #12415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an optimized deps id contains
#
symbol, it will be stripped as a URL request from the browser, which will make the asset unreachable.For example
There will be a file named
es5-ext_string_#_contains.js
in.vite/deps
after pre-bundle. And this file will be visited ashttp://localhost:5173/node_modules/.vite/deps/es5-ext_string_#_contains.js?v=ebf1e6a3
in the browser. Then the#
symbol and characters behind it will be stripped by the browser.Additional context
This PR replaced
#
with[sharp]
, which may confuse the user. But I can't figure out a better replacement :(What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).