perf(resolve): fix browser mapping nearest package.json check #12550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
p4-important
|
|
patak-dev
previously approved these changes
Mar 23, 2023
patak-dev
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're passing a file path to
findNearestPackageDatawhich causes it to stat/Users/foo/bar.js/package.jsonconstantly, andfs.statSynceven withthrowIfNoEntrythrows an error in that case withENOTDIR: not a directory, stat.This PR ensures we're passing a dir path instead to prevent the issue, so it's one less directory to check, and no errors will happen from
fs.statSync.Additional context
This brings down my previous tests of prebundling speed, from 2s to 1.4s
(100ms comes from recent refactors from patak it seems 🎉 )
What is the purpose of this pull request?