Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): dont pretransform public scripts #12650

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 29, 2023

Description

Fix #12643

Skip pre-transforming public scripts by checking with checkPublicFile for transformed URLs first.

While this leads to a potential fs check, I think it's still faster than a roundtrip browser request.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Mar 29, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev enabled auto-merge (squash) March 29, 2023 10:12
@patak-dev patak-dev merged commit 4f0af3f into main Mar 29, 2023
@patak-dev patak-dev deleted the fix-pretransform-public branch March 29, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR_LOAD_PUBLIC_URL happens when <script src="/file-in-public.js"> exists
2 participants