Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: import.meta.url condition from renderChunk hook of worker plugin #12696

Merged
merged 1 commit into from
Apr 2, 2023
Merged

refactor: import.meta.url condition from renderChunk hook of worker plugin #12696

merged 1 commit into from
Apr 2, 2023

Conversation

sapphi-red
Copy link
Member

Description

This condition was no longer needed after
6d95225#diff-3b7bb11b5633d82f82c069037789e105005d657667b1da1e96c18fcf3eb622adL352-L357

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Apr 2, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit fdef8fd into vitejs:main Apr 2, 2023
@sapphi-red sapphi-red deleted the refactor/remove-import-meta-url branch April 2, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @patak-dev