perf: use package cache for one off resolve #12744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed on startup there are some places we're resolving package data without cache. These are only one-off resolves, so the cache would help minimize fs access, and when done, cleared to free memory.
I also made an unrelated change to
assetImportMetaUrl
😬 That should remove callingstripLiteral
on theclient.mjs
file.Additional context
I didn't notice much improvement on startup time however, ~20ms. Though it might be more obvious on other machines where fs access are more expensive.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).