Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use package cache for one off resolve #12744

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 5, 2023

Description

I noticed on startup there are some places we're resolving package data without cache. These are only one-off resolves, so the cache would help minimize fs access, and when done, cleared to free memory.

I also made an unrelated change to assetImportMetaUrl 😬 That should remove calling stripLiteral on the client.mjs file.

Additional context

I didn't notice much improvement on startup time however, ~20ms. Though it might be more obvious on other machines where fs access are more expensive.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the performance Performance related enhancement label Apr 5, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 77bf4ef into main Apr 5, 2023
@patak-dev patak-dev deleted the perf-use-package-cache branch April 5, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants