perf: parallelize imports processing in import analysis plugin #12754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patak-dev
commented
Apr 5, 2023
Comment on lines
+692
to
+693
| const acceptedUrls = mergeAcceptedUrls(orderedAcceptedUrls) | ||
| const acceptedExports = mergeAcceptedUrls(orderedAcceptedExports) |
There was a problem hiding this comment.
Merged after the Promise.all so these arrays are always ordered in the same way for each file. This isn't strictly needed but should help when debugging.
The maximum number of import statements in each file of sapphi's repo is 3-4, I think that's why. Double it, maybe it will make a difference. |
bluwy
approved these changes
Apr 6, 2023
patak-dev
deleted the
perf/parallelize-imports-processing-in-import-analysis-plugin
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement @sapphi-red's idea
I'm not seeing a perf improvement on Sapphi's test, but I think we should be able to find examples where this makes a difference.
What is the purpose of this pull request?