fix: use consistent virtual module ID in module graph

[fi3ework]

Description

When investigating #12912, I found that when accepting virtual:my-plugin:foo like below

import.meta.hot.accept(['virtual:my-plugin:foo'], { /** code */ })

This will lead to adding a /src/virtual:my-plugin:foo generated by the following code to the module graph, however, IIUC, virtual module's URL should not be calculated with the importer.

vite/packages/vite/src/node/plugins/importAnalysis.ts

Lines 744 to 747 in 229c592

	const [normalized] = await moduleGraph.resolveUrl(
	toAbsoluteUrl(url),
	ssr,
	)

---

In this PR, the test case is modified to only update the virtual module as below.

import.meta.hot.accept(
    ['virtual:file', '/@id/__x00__virtual:file'],

To fix #12912 ideally, we shall only use 'virtual:file' but the HMR dilemma now is like this:

• acceptedPath send to the client is "/@id/__x00__virtual:file"
• the acceptedPath defined in main.js must include "/@id/__x00__virtual:file" to receive the update.

I'm not sure what's the best way to fix this, but I think it's straightforward to avoid assembling URL for virtual file with the importer in this PR. Looking forward to some feedback 🙌.

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
astro	✅ success
histoire	✅ success
iles	✅ success
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	❌ failure
previewjs	✅ success
qwik	✅ success
rakkas	✅ success
sveltekit	✅ success
vite-plugin-ssr	✅ success
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	✅ success
windicss	✅ success

[patak-dev]

Ecosystem CI looks good. The Nuxt failure is in main too 👍🏼

[bluwy]

• acceptedPath send to the client is "/@id/__x00__virtual:file"

Maybe we can unwrap the id before we send it to the client? 🤔 Looks like I was the one who messed that up at #10324, I didn't add a test for that, and it was to address #10313. Maybe we should wrap the id in the client instead?

[patak-dev]

@bluwy could you explain why that would be better? I think it is more clear to me if the client already receives /@id/__x00__virtual:file", no? From the client POV, always getting valid URLs from the Vite dev server is easier to explain IMO

[bluwy]

Hmm yeah after refreshing myself of what values the acceptedPath is usually gets passed with, seems like it's always URLs, so makes sense to continuing wrapping it, but unwrapping it later in the client again.

Also I tested with /@fs/ and it looks like the /@fs/ path is sent to the client too (not sure if HMR is fine with it though)