Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): intercept ping requests #13117

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

gtm-nayan
Copy link
Contributor

Description

fixes #13109

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented May 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy previously approved these changes May 8, 2023
@bluwy bluwy changed the title fix: intercept ping requests fix(server): intercept ping requests May 8, 2023
@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label May 8, 2023
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented May 8, 2023

📝 Ran ecosystem CI: Open

suite result
astro ❌ failure
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ❌ failure
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev
Copy link
Member

/ecosystem-ci run astro

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented May 8, 2023

📝 Ran ecosystem CI: Open

suite result
astro ✅ success

patak-dev
patak-dev previously approved these changes May 8, 2023
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @sapphi-red just in case, do you see an issue with merging this one in a patch?

@sapphi-red sapphi-red dismissed stale reviews from patak-dev and bluwy via 0e58633 May 8, 2023 15:25
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't come up with any issues merging this in a patch. 👍

@patak-dev
Copy link
Member

Good catch with the named middleware @sapphi-red, thanks!

@patak-dev patak-dev merged commit d06cc42 into vitejs:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ping requests reach the user defined middlewares
4 participants