perf: skip windows absolute paths for node resolve #13162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found that
C:/non-existent-path
goes through this part while debugging #13158.vite/packages/vite/src/node/plugins/resolve.ts
Lines 326 to 407 in 23096b1
vite-tsconfig-paths
seems to callthis.resolve('C:/project/packageName')
. I guess it's fortsconfig.compilerOptions.baseUrl
I'm not sure if this is worth doing. I don't have a good test case for this. I guess it would improve perf for a large project using
vite-tsconfig-paths
.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).