Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon): template-vanilla add favicon.ico #1340

Closed
wants to merge 1 commit into from
Closed

fix(icon): template-vanilla add favicon.ico #1340

wants to merge 1 commit into from

Conversation

linbingquan
Copy link

Bug report:

  1. Use template: vanilla js.
  2. Run yarn and yarn build.
  3. Something warn in terminal like this.
PS D:\MyProjects\vite-helloworld> yarn build
yarn run v1.22.10
warning package.json: No license field
$ vite build
building for production...
[vite:build-html] ENOENT: no such file or directory, open 'D:\MyProjects\vite-helloworld\favicon.ico'
file: /MyProjects/vite-helloworld/index.html
error during build:
Error: ENOENT: no such file or directory, open 'D:\MyProjects\vite-helloworld\favicon.ico'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@yyx990803 yyx990803 closed this in d9df7eb Jan 4, 2021
@yyx990803
Copy link
Member

Thanks, I think it's better to just remove it.

@linbingquan
Copy link
Author

linbingquan commented Jan 4, 2021 •
edited
Loading

Thank you for your reply. Is this what you want. Should I make a PR to fix it.

diff --git a/packages/create-app/template-vanilla/index.html b/packages/create-app/template-vanilla/index.html
index e4f0209..60fd73f 100644
--- a/packages/create-app/template-vanilla/index.html
+++ b/packages/create-app/template-vanilla/index.html
@@ -2,7 +2,6 @@
 <html lang="en">
 <head>
   <meta charset="UTF-8">
-  <link rel="icon" href="/favicon.ico" />
   <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <title>Vite App</title>
 </head>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linbingquan @yyx990803