-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean up changelog, downgrade conventional-changelog-cli to v2 #13566
Conversation
Run & review this pull request in StackBlitz Codeflow. |
@patak-dev If you find a way to fix it, please reference it in this issue so that I can apply it on my side too, thanks EDIT |
EDIT 2 So in my case, the issue I had was with Vitest when running unit tests, I had opened an issue on the Vitest project and a fix was pushed and I also had to use this setting (as per sheremet-va comment)
I don't have the issue that was identified in this PR but still, I was able to move forward :) Cheers and ❤️ Vite/Vitest 🚀 |
@patak-dev @bluwy Hi. Could you please try this to solve issue with conventional-changelog-cli@3 ? |
@dangreen Yeah with |
If you will have other issues with conventional-changelog feel free to ping me. |
Thanks for the update. The upgrade PR is at #13634 and we'll merge in some time next week during the Vite v5 beta to test it out again. |
Thanks @dangreen, we merged the upgraded version. It looks good in a dry run now. |
Description
There seems to be a regression in conventional-changelog-cli@3. It didn't detect the last released version and it re-generated the whole changelog from vite 2. @brc-dd had the same issue in VitePress. Let's downgrade for now.
What is the purpose of this pull request?