Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up changelog, downgrade conventional-changelog-cli to v2 #13566

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

patak-dev
Copy link
Member

Description

There seems to be a regression in conventional-changelog-cli@3. It didn't detect the last released version and it re-generated the whole changelog from vite 2. @brc-dd had the same issue in VitePress. Let's downgrade for now.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Jun 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the p1-chore Doesn't change code behavior (priority) label Jun 20, 2023
@patak-dev patak-dev merged commit 435bacc into main Jun 20, 2023
@patak-dev patak-dev deleted the fix/downgrade-conventional-changelog-cli branch June 20, 2023 10:07
@ghiscoding
Copy link
Contributor

ghiscoding commented Jun 20, 2023

@patak-dev
hey guys, I've also noticed some kind of regression in Lerna-Lite, that I maintain, when I tried to upgrade all conventional-changelog packages to their new major versions (Lerna/Lerna-Lite uses a few of their packages). I didn't have time to investigate much but from what I could find so far, I can no longer use ESM dynamic imports with conventional-changelog-angular, basically this code await import('conventional-changelog-angular') now fails with Vitest but does not fail in previous version (not sure if it works outside of Vitest) and I'm assuming you guys probably have the same kind of problem and I also downgraded for that reason all their packages for that reason.

If you find a way to fix it, please reference it in this issue so that I can apply it on my side too, thanks

EDIT
Actually I might have misread since your issue seems different than mine. BTW, their biggest change was to remove the Q library and go with native Promise.

@ghiscoding
Copy link
Contributor

ghiscoding commented Jul 14, 2023

EDIT 2

So in my case, the issue I had was with Vitest when running unit tests, I had opened an issue on the Vitest project
vitest-dev/vitest#3705

and a fix was pushed and I also had to use this setting (as per sheremet-va comment)

For your case, you can just disable deps.interopDefault. But I will look into it more

I don't have the issue that was identified in this PR but still, I was able to move forward :)

Cheers and ❤️ Vite/Vitest 🚀

@dangreen
Copy link

dangreen commented Aug 4, 2023

@patak-dev @bluwy Hi. Could you please try this to solve issue with conventional-changelog-cli@3 ?

@brc-dd
Copy link
Contributor

brc-dd commented Aug 4, 2023

@dangreen Yeah with conventional-changelog-writer: 6.0.1 it works fine.

@dangreen
Copy link

dangreen commented Aug 4, 2023

If you will have other issues with conventional-changelog feel free to ping me.

@bluwy
Copy link
Member

bluwy commented Aug 6, 2023

Thanks for the update. The upgrade PR is at #13634 and we'll merge in some time next week during the Vite v5 beta to test it out again.

@patak-dev
Copy link
Member Author

Thanks @dangreen, we merged the upgraded version. It looks good in a dry run now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants