chore: show error position #13623
Merged
chore: show error position #13623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p2-nice-to-have
|
|
sapphi-red
commented
Jun 25, 2023
Comment on lines
-224
to
+226
| this.error(e) | ||
| this.error(e, e.idx) |
There was a problem hiding this comment.
This this.error is in the transform hook. This was removed by mistake in #13608.
| meta = minimalContext.meta! | ||
| meta = minimalContext.meta |
There was a problem hiding this comment.
This ! wasn't needed but added by #13608.
patak-dev
approved these changes
Jun 25, 2023
ailadas
added a commit
to ailadas/vite
that referenced
this pull request
Jun 25, 2023
This reverts commit 90271a6.
This was referenced Jun 25, 2023
xinxinhe1810
pushed a commit
to xinxinhe1810/vite
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #13608.
#13608 removed the second argument of
this.errorin some places. This is correct asthis.erroronly receives the second argument in thetransformhook.That said, it would be better to pass the
posand other properties to give rollup more information to generate a friendly error.This PR adds those information.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).