fix: revert #13073, use consistent virtual module ID in module graph #13734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa1776f.
|
|
dominikg
approved these changes
Jul 6, 2023
This comment was marked as resolved.
This comment was marked as resolved.
7 tasks
|
No problem. I forgot to unlock it 😅 |
|
@patak-dev Would it make sense to merge #13073 again as part of v5? This would give storybook the correct opportunity and time to address the breaking change? |
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit aa1776f.
Fixes storybookjs/storybook#23338
Description
Let's revert #13073 so we can patch vite 4.4. We can check why Storybook is failing with more time and reapply the fix. cc @fi3ework
What is the purpose of this pull request?