fix(build): mixed external and transpiled srcset #14888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
added
the
p3-minor-bug
|
|
bluwy
previously approved these changes
Nov 7, 2023
sapphi-red
reviewed
Nov 7, 2023
sapphi-red
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The two commits could be merged separately.
Follow up to #14870, fixing the commented-out test during build added in the PR.
The first commit is a refactor to avoid some "is public" checks and avoid confusion with
isExcluded, as public urls are transpiled.The second commit is the fix. The URLs are overwritten in parallel after these changes, and they are only replaced if the decoded URL is different from the processed URL. Before it was always replaced, so we were changing encoded URLs to decoded ones even if no transpilation is needed.
What is the purpose of this pull request?