fix(ssr): support externalized builtins for webworker #15656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
webworker builds such as Cloudflare these days support ESM and nodejs compat modules. So some framework may choose to
noExternal: true
but externalize the nodejs builtins so that they can be used in the runtime.Currently our hardcoded "if
ssrNoExternal === true
=> error" flow, blocks bundling when encountering imports to the builtin. To be consistent with the new description in Vite 5.1:https://main.vitejs.dev/config/ssr-options.html#ssr-noexternal
If the builtins are specified in
ssr.external
, we will now allow bundling it.Additional context
I thought about re-using
shouldExternalize
to update the conditions, but it has its internalisBuiltin
check that doesn't make it work.This PR could also unblock frameworks to do a single Vite build, instead of needing a secondary esbuild bundle for cloudflare worker builds.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).