Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-app): prompt the user on supplying an invalid template #2072

Merged
merged 1 commit into from
Feb 18, 2021
Merged

fix(create-app): prompt the user on supplying an invalid template #2072

merged 1 commit into from
Feb 18, 2021

Conversation

jamesgeorge007
Copy link
Contributor

Current behavior

An attempt to create a new vite project fails if the user makes a typo while supplying the template (or maybe an unsupported template).

$ yarn create @vitejs/app app -t default

Screenshot 2021-02-18 at 4 52 17 PM

Proposed change

Screenshot 2021-02-18 at 5 00 42 PM

@jamesgeorge007 jamesgeorge007 changed the title fix: prompt the user on supplying an invalid template fix(create-app): prompt the user on supplying an invalid template Feb 18, 2021
@yyx990803 yyx990803 merged commit ea31690 into vitejs:main Feb 18, 2021
@jamesgeorge007 jamesgeorge007 deleted the hotfix/create-app branch February 18, 2021 17:34
@jamesgeorge007 jamesgeorge007 mentioned this pull request Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesgeorge007 @yyx990803