feat: default build.minify to esbuild

[yyx990803]

• Bump esbuild to 0.13 which ships with new tree-shaking behavior
• Default build.minify to esbuild, which is 20 ~ 40x faster than terser and only 1 ~ 2% worse compression. Benchmarks
• Will log warning if terserOptions was previously specified

Caveats

• esbuild@13 now uses a new installation strategy for installing platform specific binaries, which uses optionalDependencies (details in its changelog). The only downside is that all versions of Yarn will download binaries for all platforms (and eventually only install one), so installing with Yarn will become significantly slower. Not sure if there is a way around this - maybe we should encourage users to use npm/pnpm and avoid Yarn. (And we should probably switch to pnpm in the vite repo itself)

[benmccann]

+1 to switching to pnpm. It's quite hard to test Vite changes against SvelteKit right now because the latter uses pnpm. If both projects were to use pnpm then we could do pnpm link, which would make life much easier

[yyx990803]

Unfortunately our current test setup relies quite heavily on Yarn's node_modules layout. I tried to move to pnpm but many of the tests are breaking due to not being able to resolve correctly when copied to a different temp directory.

[bluwy]

Another trouble with pnpm right now is that there's no differentiation between file: and link: protocol. In yarn, they are "copy" and "symlink" operations, while pnpm treats both as "symlink". We would need this separation so we can properly test dependency crawling and optimizaton.

[yyx990803]

I managed to get a decent amount of tests passing under pnpm in a WIP branch: https://github.com/vitejs/vite/tree/pnpm

There are a few tests still failing but I think eventually we should be able to move over.

[dominikg]

Unfortunately our current test setup relies quite heavily on Yarn's node_modules layout. I tried to move to pnpm but many of the tests are breaking due to not being able to resolve correctly when copied to a different temp directory.

Ran into this aswell when i converted vite-plugin-svelte to pnpm. I resorted to symlinking packages/playground/xxx/node_modules to /temp/serve/xxx/node_modules

https://github.com/sveltejs/vite-plugin-svelte/blob/f112d8b4bb029ca98eed500907d3e79308724eb8/scripts/jestPerTestSetup.ts#L107

iirc vite doesn't use /temp/serve and /temp/build for separate test dirs, but the pattern could still apply

edit: I'm pretty stoked about the pnpm move too. Tops my list of great news for vite this week. ❤️

[dominikg]

Another one for pnpm.. You can use .pnpmfile.cjs to enforce consistent use of workspace dependencies even inside 3rd party dependencies that might be present in playground projects:
https://github.com/sveltejs/vite-plugin-svelte/blob/main/.pnpmfile.cjs

See comment