fix(config): Warn about terserOptions in more cases #7101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, the warning wasn't issued when build.minify wasn't set (i.e. the value was `undefined`), but in the end the config defaulted to esbuild
bluwy
approved these changes
Feb 26, 2022
bluwy
added
the
p2-nice-to-have
ydcjeff
approved these changes
Feb 27, 2022
patak-dev
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the warning wasn't issued when build.minify wasn't set (i.e. the value was
undefined), but in the end the config defaulted to esbuildDescription
Additional context
Related to #5041
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).