Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): escape pattern chars from base path in postcss dir-dependency messages #7081

Merged

Conversation

thecrypticace
Copy link
Contributor

Description

fast-glob is used by Vite when resolving dir-dependency messages from PostCSS. Certain characters are considered special characters in a glob, for example (, and ). If a directory has these somewhere in it's absolute path the base path will be stripped down to the directory before these occur and the glob will result in no files. This PR escapes the base directory before concatenating it and passing it to fast-glob so paths with special characters are supported.

Additional context

n/a


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@thecrypticace thecrypticace changed the title fix(css): escape pattern chars in postcss dir-dependency messages fix(css): escape pattern chars from base path in postcss dir-dependency messages Feb 25, 2022
@bluwy bluwy added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Feb 25, 2022
@patak-dev patak-dev merged commit 5151e74 into vitejs:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants