-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssr): dont replace rollup input #7275
Conversation
Can you describe more about why this change is required? |
Basically, the
Notice that we already generate the final input, using rollupConfig when necessarily... But this value is override and never used because this line: replaces it. |
I see. For your example, which input do you expect to pass to the rollup since it now has ssr entry and |
I would expect to use the one I passed in |
Any updates? |
Sorry @manucorporat, I missed this one til now |
Per #9086, it seems this may have gone a little too broad. Any thoughts on how to rein it back in a bit? Or is my use case now officially unsupported? |
Description
Setting custom input in rollupConfig always replaces, even the ssr entry points.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).