-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: worker support query url #7914
Conversation
It seems this PR supersedes #5845. |
oh, If the Author goto rebase and complementing his missing parts of this I will close this. |
I'd still be in favour of this PR though as it has more tests and refactors 🙂 |
For reference, we talked with the team about the PR and we are good to merge it. We tried to find a way to avoid introducing new URL queries but this feature justifies the addition, and there doesn't seem to be any other way until the standard evolves to support modifiers. Let's merge the PR once it is rebased. |
May be we can clean all the url query in vite@4 😁 |
Description
fix: #7569
Additional context
feat support below syntax to import worker url.
about
new URL
I think
new URL
is better not to add too much non-conforming syntax, so I do not support it now. And if the href is not added to break theworkerImportMetaUrl
match, it may make another issuesFor example:
And doing a little refactor, I think worker related logic should be in
worker.ts
.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).