-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sourcemap source point to null #8299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poyoho
changed the title
chore: force setting
chore: set sourcemap source
May 25, 2022
sourcemap: true
in dev
sapphi-red
requested changes
May 29, 2022
playground/worker/__tests__/sourcemap/__snapshots__/sourcemap-worker.spec.ts.snap
Outdated
Show resolved
Hide resolved
sapphi-red
previously approved these changes
May 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
patak-dev
reviewed
May 29, 2022
patak-dev
approved these changes
May 29, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #8289 (comment)
For example:
if the file just transform by
importMetaGlob
plugin it will got an error.Additional context
in dev mode if plugin no generate map field, will generate by middleware.
https://github.com/vitejs/vite/blob/main/packages/vite/src/node/server/pluginContainer.ts#L649
I think we can resolve it by setting
generateMap({ source: id })
likepluginContainer
default generate sourcemap.force setbuild.sourcemap === true
when in dev mode, but I think force setting of this value may confuse users whenresolvingConfig
hookWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).