fix: SSR deep imports externalization (fixes #8420) #8421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
previously approved these changes
May 31, 2022
patak-dev
changed the title
|
Tested SvelteKit and it is building after: We'll need to add later a .css dep in ssr test case in our CI |
patak-dev
added
p3-downstream-blocker
aleclarson
reviewed
Jul 17, 2022
| // check ext before externalizing - only externalize | ||
| // extension-less imports and explicit .js imports | ||
| if (resolvedExt && !resolved.id.match(/(.js|.mjs|.cjs)$/)) { | ||
| return |
There was a problem hiding this comment.
Is this meant to be return resolved?
There was a problem hiding this comment.
No, it should return undefined. The only way this code is reached is when called to test if it should be externalized here. I should have added a comment there
Once this returns undefined, the second tryNodeResolve in the resolve plugin will already have
externalize false so it wont reach the branch. This is quite confusing though. It was done as part of a refactoring that tried to not change too much of the current structure. Now that we know the new SSR externals logic is working, we should do another refactoring to clean up and avoid the need to calling tryNodeResolve twice (the ssr check is cached, so it is only duplicated the first time but still)
There was a problem hiding this comment.
Oh wow that is very confusing, haha 😆
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the error reported by @benmccann here #8420
But after this fix, SvelteKit is still not building as there is an issue with .css imports
We can still merge this one while we work on the other issue.
What is the purpose of this pull request?