lodash/cloneDeep and lodash.clonedeep: Two output files share the same path but have different contents.

[tajo]

Describe the bug

When importing from lodash/cloneDeep and lodash.clonedeep in the same project, vite (or esbuild) throws:

✘ [ERROR] Two output files share the same path but have different contents: node_modules/.vite/processing/lodash_cloneDeep.js

This should not be an issue since those are two different packages and vite should create two different pre-bundled modules.

It might be because / and . gets normalized to _ and a colliding filename is created? There were some previous references of this issue in vite pointing to lower/upper case but this seems to be a different problem.

Reproduction

https://stackblitz.com/edit/vitejs-vite-fpc1de

System Info

stackblitz template

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[patak-dev]

Interesting, yes, I think we need to encode _ and . differently. PR welcome if you would to work on this, if not I'll check it 👍🏼
See

vite/packages/vite/src/node/utils.ts

Line 39 in 5ab336a

export const flattenId = (id: string): string =>

[btea]

Interesting, yes, I think we need to encode _ and . differently. PR welcome if you would to work on this, if not I'll check it 👍🏼 See

vite/packages/vite/src/node/utils.ts

Line 39 in 5ab336a

export const flattenId = (id: string): string =>

Why replace / and . with _ here?

[tajo]

Why replace / and . with _ here?

Afaik, it's used for the cached files so / needs to be replaced. But should be fine to just preserve .?

[btea]

@tajo Thanks for your reply, it looks like it does.