Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-legacy): prevent esbuild injecting arrow function (fixes #8651) #8660

Merged

Conversation

sapphi-red
Copy link
Member

Description

Previously core-js was bundled by @rollup/plugin-commonjs but now it is bundled by esbuild.
esbuild injects helper functions and it uses ES2015 features when target is above ES5.

fixes #8651

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: legacy p4-important Violate documented behavior or significantly improves performance (priority) labels Jun 19, 2022
@patak-dev patak-dev merged commit c0e74e5 into vitejs:main Jun 19, 2022
@sapphi-red sapphi-red deleted the fix/legacy-containing-arrow-function branch June 20, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Violate documented behavior or significantly improves performance (priority) plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

since Vite 3.0.0-alpha.5 with 2.0.0 -alpha.1 legacy plugin is producing code incompatible with ie 11
3 participants