-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: respect esbuild minify config #8754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
the
p2-nice-to-have
Not breaking anything but nice to have (priority)
label
Jun 24, 2022
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I think setting export interface ESBuildOptions extends TransformOptions {
include?: string | RegExp | string[] | RegExp[]
exclude?: string | RegExp | string[] | RegExp[]
jsxInject?: string
/** This option is not respected. Use `build.minify` instead. */
minify?: never
} export default defineConfig({
esbuild: {
minify: true // type error here. jsdoc will show the reason
}
}) |
sapphi-red
reviewed
Jun 24, 2022
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
sapphi-red
previously approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nitpick but other LGTM ✨
Co-authored-by: 翠 / green <green@sapphi.red>
sapphi-red
approved these changes
Jun 25, 2022
patak-dev
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #6065
Additional context
Been thinking about the issue, and maybe it make sense to scope minify to certain aspects only.
Logic:
minify*
options are specified, use them instead ofminify: true
(which overrides all the specific options totrue
)minify: true
minifyWhitespace
is false for es library build.Other improvements
minifySyntax
andminifyIdentifiers
as those are safe.build.minify: false
, regardless ofesbuild.minify
andesbuild.minify*
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).