Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deps optimizer waits for every requested module #8822

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

patak-dev
Copy link
Member

Description

We were only registering ids statically imported. This PR moves the registration after resolving the id transformRequest ensuring that we wait on every module the browser is loading.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev changed the title fix: deps optimizer should wait on entries fix: deps optimizer waits for every requested module Jun 27, 2022
@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 4d1d1a6
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62ba06848cca3e0009807c41

@patak-dev patak-dev merged commit 2db1b5b into main Jun 28, 2022
@patak-dev patak-dev deleted the fix/deps-optimizer-wait-on-entries branch June 28, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant